# PR comments and update for openfhe-python

**URL:** <https://openfhe.discourse.group/t/pr-comments-and-update-for-openfhe-python/1869>\
**Category:** OpenFHE ports/wrappers\
**Created:** [February 11, 2025, 11:45pm UTC](https://openfhe.discourse.group/t/pr-comments-and-update-for-openfhe-python/1869 "2025-02-11T23:45:41Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![ai-mannamalai](https://avatars.discourse-cdn.com/v4/letter/a/59ef9b/32.png) [@ai-mannamalai](https://openfhe.discourse.group/u/ai-mannamalai)\
**Post date:** [February 11, 2025, 11:45pm UTC](https://openfhe.discourse.group/t/pr-comments-and-update-for-openfhe-python/1869/1 "2025-02-11T23:45:41Z")

</div>

Hi there:  
I’m contributing to OpenFHE Python from last year; today I’m pushing a new PR to allow for len() method for Ciphertext and Keys in Openfhe-Python/dev branch [here](https://github.com/openfheorg/openfhe-python/pull/193).

Besides, I have reviewed the other two pending PRs, which seem to be OK to merge per me.

1. Error message update looks good as well: PR #192
2. Docker instance with Jupyter looks good as well : [PR](https://github.com/openfheorg/openfhe-python/pull/181)

---

<div class="post-metadata">

**Author:** ![dsuponitskiy-duality](https://avatars.discourse-cdn.com/v4/letter/d/c68b51/32.png) [@dsuponitskiy-duality](https://openfhe.discourse.group/u/dsuponitskiy-duality)\
**Post date:** [March 3, 2025, 4:15pm UTC](https://openfhe.discourse.group/t/pr-comments-and-update-for-openfhe-python/1869/2 "2025-03-03T16:15:16Z")

</div>

@ai-mannamalai I will review them. Hopefully today

---

<div class="post-metadata">

**Author:** ![dsuponitskiy-duality](https://avatars.discourse-cdn.com/v4/letter/d/c68b51/32.png) [@dsuponitskiy-duality](https://openfhe.discourse.group/u/dsuponitskiy-duality)\
**Post date:** [March 3, 2025, 7:16pm UTC](https://openfhe.discourse.group/t/pr-comments-and-update-for-openfhe-python/1869/3 "2025-03-03T19:16:24Z")

</div>

@ai-mannamalai Seems like [this PR](https://github.com/openfheorg/openfhe-python/pull/181) can be just closed without merging

---

<div class="post-metadata">

**Author:** ![dsuponitskiy-duality](https://avatars.discourse-cdn.com/v4/letter/d/c68b51/32.png) [@dsuponitskiy-duality](https://openfhe.discourse.group/u/dsuponitskiy-duality)\
**Post date:** [March 3, 2025, 7:41pm UTC](https://openfhe.discourse.group/t/pr-comments-and-update-for-openfhe-python/1869/4 "2025-03-03T19:41:02Z")

</div>

@ai-mannamalai unittests failed for [PR.](https://github.com/openfheorg/openfhe-python/pull/193)

---

<div class="post-metadata">

**Author:** ![dsuponitskiy-duality](https://avatars.discourse-cdn.com/v4/letter/d/c68b51/32.png) [@dsuponitskiy-duality](https://openfhe.discourse.group/u/dsuponitskiy-duality)\
**Post date:** [March 18, 2025, 6:52pm UTC](https://openfhe.discourse.group/t/pr-comments-and-update-for-openfhe-python/1869/5 "2025-03-18T18:52:27Z")

</div>

@ai-mannamalai Please check my update to your PR

---

<div class="post-metadata">

**Author:** ![ai-mannamalai](https://avatars.discourse-cdn.com/v4/letter/a/59ef9b/32.png) [@ai-mannamalai](https://openfhe.discourse.group/u/ai-mannamalai)\
**Post date:** [May 20, 2025, 10:48pm UTC](https://openfhe.discourse.group/t/pr-comments-and-update-for-openfhe-python/1869/6 "2025-05-20T22:48:18Z")

</div>

Seems like the parameter 78 for setModSize is incorrect;

```auto
Failure in case:

> E RuntimeError: /home/ubuntu/actions-runner/_work/openfhe-python/openfhe-python/openfhe-development/src/pke/lib/scheme/gen-cryptocontext-params-validation.cpp:l.50:validateParametersForCryptocontext(): scalingModSize should be less than 28

Ref: https://github.com/openfheorg/openfhe-python/actions/runs/13638593457/job/38123130569

```